John if the jars are airtight and kept in a dark cool place they should have just been passable I would have thought but not ideal. I have a feeling that may have been your main problem and the smell is derived from not just the spices but the fried onion garlic etc. so it will still smell fine.
I suggest whatever you do next ditch those old spices and buy small packets of fresh spices (reach to the back of the shelf where they keep the longest dated ones

). Small packets get used more quickly so you're forced to buy new fresh ones often - assuming you're making a decent amount of curries of course. Each packet of spices I buy lasts for about six weeks at most, usually fewer.